Colour Palettes Not Displaying Colours

Started by kalm, October 21, 2015, 07:52:03 PM

Previous topic - Next topic

kalm

The latest build ... 1.1.0.93 i think crashed whilst trying to save a pallete, and then I don't think the crash report worked, as the whole thing hung. I had to use task manager to close it.

Richard Moss

Thanks for the report. I've actually been trying to repro it as I had a similar report from another user for build 82 (I have no reports from build 93). It seems to be because it has "forgot" what file type it is supposed to be (adobe, gimp etc), so promptly crashes when it tries to save in that format. Can't seem to work out how that is happening though... I shall keep digging.

kalm

I think the default palette was .act ... I was trying to save as .aco when it crashed, and I can reproduce it. Every time actually. It's not reproducing it that's the issue!

Richard Moss

#18
I fired up a fresh blank VM and I still can't get it to crash. There is an oddity where the filter defaults to the first item in the list, ignoring the current file type and it is the filter that is used to determine the output type. Not noticing this can then cause a save fail if you try, for example, to save 257 colors into an act file, but that isn't a crash. I shall fix that filter issue now but I still can't repro the crash.

Edit: Filter bug at least is now fixed in build 98 or higher

kalm

#19
Richard, the crash only seem to occur when starting with a new blank palette. If I start with a new palette and without doing anything, go to save as, then it crashes immediately. If I rename a palette and delete colours until I get to the number I want, and then recolour them, I can save what I need, so there is a workable alternative.

Even better news, using the newly created palette in my CAD system shows the colours as they should, and no longer shown a multitude of black squares, so your fix looks to be perfect. Thank you very much.


Richard Moss

As simple as that? All this time I'd been doing Save with empty files, and Save As with existing ones, as I always code the applications to treat Save as a Save As if the document has never been saved before. Except this time there is a subtle switch between current and pending serializers. Actually swearing at my monitor at little here  :-[

With that said, bug squashed and will be in the next build. Next task is to work out why EmptySave/SaveAs aren't the same and fix that too.

Glad to hear the ACO issues are all resolved, thanks for letting me know!